drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments
authorLyude Paul <lyude@redhat.com>
Wed, 23 Nov 2022 19:50:16 +0000 (14:50 -0500)
committerSalvatore Bonaccorso <carnil@debian.org>
Sun, 29 Jan 2023 12:33:36 +0000 (12:33 +0000)
commit12c7acbd23eed381028ef1570a1031876b3c5f11
treeb34b3ef5d3a1b0fe2c5f2ed50ff23cde877f4ae7
parent1b700793f0c76cf011cca8b43d64bcffa2330783
drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments

Origin: https://git.kernel.org/linus/1119e1f9636b76aef14068c7fd0b4d55132b86b8
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2171
Bug-Debian: https://bugs.debian.org/1028451

Looks like I made a pretty big mistake here without noticing: it seems when
I moved the assignments of mst_state->pbn_div I completely missed the fact
that the reason for us calling drm_dp_mst_update_slots() earlier was to
account for the fact that we need to call this function using info from the
root MST connector, instead of just trying to do this from each MST
encoder's atomic check function. Otherwise, we end up filling out all of
DC's link information with zeroes.

So, let's restore that and hopefully fix this DSC regression.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2171
Signed-off-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Fixes: 4d07b0bc4034 ("drm/display/dp_mst: Move all payload info into the atomic state")
Cc: stable@vger.kernel.org # 6.1
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Didier Raboud <odyx@debian.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name drm-amdgpu-display-mst-Fix-mst_state-pbn_div-and-slo.patch
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c